Develop
Ticket #996 (assigned defect)
SEGV when choosing "GoTo And Clear Task"
| Reported by: | JamesB | Owned by: | RobD |
|---|---|---|---|
| Priority: | normal | Milestone: | XCSoar Wishlist |
| Component: | Task | Version: | 6.1 |
| Keywords: | Cc: |
Description
Start xcsoar. Select a TP to open the waypoint details and choose "GoTo?". Then select the TP again, now choose "GoTo? And Clear Task". Repeat the last step again.
Program received signal SIGSEGV, Segmentation fault.
0x0000000000548174 in GotoTask::reset (this=0x10a05c0) at src/Engine/Task/Tasks/GotoTask.cpp:106
106 delete tp;
(gdb) bt
#0 0x0000000000548174 in GotoTask::reset (this=0x10a05c0) at src/Engine/Task/Tasks/GotoTask.cpp:106
#1 0x00000000005391ec in TaskManager::reset (this=0x109ed40) at src/Engine/Task/TaskManager.cpp:363
#2 0x00000000004dccdd in goto_and_clear_task (wp=...) at src/Dialogs/dlgWayPointDetails.cpp:416
#3 0x00000000004dce22 in OnGotoAndClearTaskClicked (button=...) at src/Dialogs/dlgWayPointDetails.cpp:443
#4 0x00000000004ef5ae in WndButton::on_clicked (this=0x164c260) at src/Form/Button.cpp:47
#5 0x00000000004fcd59 in ButtonWindow::on_mouse_up (this=0x164c260, x=22, y=39) at src/Screen/SDL/ButtonWindow.cpp:106
#6 0x00000000004fbb3c in ContainerWindow::on_mouse_up (this=0x1627640, x=102, y=299) at src/Screen/SDL/ContainerWindow.cpp:257
#7 0x00000000004fbb3c in ContainerWindow::on_mouse_up (this=0x1621290, x=254, y=299) at src/Screen/SDL/ContainerWindow.cpp:257
#8 0x00000000004fbb3c in ContainerWindow::on_mouse_up (this=0x16211b0, x=254, y=321) at src/Screen/SDL/ContainerWindow.cpp:257
#9 0x00000000004fbb3c in ContainerWindow::on_mouse_up (this=0x959ca0, x=254, y=321) at src/Screen/SDL/ContainerWindow.cpp:257
#10 0x00000000004fe0c1 in TopWindow::on_event (this=0x959ca0, event=...) at src/Screen/SDL/TopWindow.cpp:219
#11 0x00000000004fee82 in EventLoop::dispatch (this=0x7fffffffb9c0, event=...) at src/Screen/SDL/Event.cpp:61
#12 0x00000000004ee964 in WndForm::ShowModal (this=0x16211b0, mouse_allowed=0x0) at src/Form/Form.cpp:490
#13 0x00000000004de144 in dlgWayPointDetailsShowModal (parent=..., way_point=..., allow_navigation=true)
at src/Dialogs/dlgWayPointDetails.cpp:750
#14 0x000000000044be5f in PopupNearestWaypointDetails (way_points=..., location=..., range=1562.5, scalefilter=true)
at src/Dialogs/Dialogs.cpp:53
#15 0x0000000000475747 in GlueMapWindow::on_mouse_up (this=0x959db0, x=132, y=301) at src/GlueMapWindowEvents.cpp:231
#16 0x00000000004fbb3c in ContainerWindow::on_mouse_up (this=0x959ca0, x=132, y=301) at src/Screen/SDL/ContainerWindow.cpp:257
#17 0x00000000004fe0c1 in TopWindow::on_event (this=0x959ca0, event=...) at src/Screen/SDL/TopWindow.cpp:219
#18 0x00000000004fee82 in EventLoop::dispatch (this=0x7fffffffe1a0, event=...) at src/Screen/SDL/Event.cpp:61
#19 0x00000000004fe111 in TopWindow::event_loop (this=0x959ca0) at src/Screen/SDL/TopWindow.cpp:233
#20 0x00000000004e566c in main (argc=1, argv=0x7fffffffe2f8) at src/XCSoar.cpp:85
Change History
comment:1 Changed 14 months ago by jwharington
- Owner set to jwharington
- Status changed from new to assigned
comment:2 Changed 14 months ago by jwharington
- Status changed from assigned to closed
- Resolution set to fixed
fixed in my rebasing.
comment:3 Changed 14 months ago by RobD
- Status changed from closed to reopened
- Resolution fixed deleted
John pls look at ticket 501. I believe the desired behavior is to clear and start an ordered task via the map /WP details screen.
comment:4 Changed 14 months ago by jwharington
There are several problems here:
1/ the function as implemented did not do what it was called.
If it were called "create new task here", then that would be ok.
But as it was, it confused goto and ordered tasks.
2/ the implementation was broken
3/ i think it crowds the buttons, too easy to accidentally press
I think the function and button should be deleted, and
have the task manager ask on entry, if the current task is goto, whether to convert that to an ordered task.
comment:5 Changed 14 months ago by RobD
Agree on all points
User really wants map-centric task builder.
Suggest for 6.1 we either remove button entirely until we design interface that supports this or rename button to "Clear Task And Append" with that logic
